Re: completion for rsync?

[Anthony R Iano-Fletcher <Anthony.Iano-Fletcher@xxxxxxxxxxxxxxxx>]

Hello 

Thank you, Sven, for your comments.

> > #compdef fping
> > 
> > 
> > _arguments -C \
> > ...
> >    '-u[show targets that are unreachable]:' \
> >    && ret=0
> 
> Shouldn't the follwing be replaced by an argument-spec calling _hosts
> (it's the same code anyway) and the `&& ret=0' be removed (it's not
> defined as a local and not initialised to `1')?

I removed the '&& ret=0'. I followed the recipe from another completion
function... hence the extra cruft. Likewise I have some extra colons in
the options.

You mean something like:
	_wanted hosts expl 'host name' _hosts
That does work better.....

I'm attaching the next version...... criticism is welcome.

Do I still need this line?
> > local expl hosts

I am just starting to get to grips with the new completion stuff after
putting it off for years. You've all done a great job with the default
completions that most of the job is done. Thanks.

			Anthony.

-- 
Anthony R Iano-Fletcher        Anthony.Iano-Fletcher@xxxxxxx
                               http://cbel.cit.nih.gov/~arif
                               CBEL, CIT, NIH, Bethesda, MD, USA.
                               Phone: (+1) 301 402 1741.

#compdef fping

local expl hosts

_arguments -C \
   '-a[show targets that are alive]' \
   '-A[show targets by address]' \
   '-v[show version]' \
   '-b n[amount of ping data to send, in bytes (default 56)]:' \
   '-B f[set exponential backoff factor to f]:' \
   '-c n[count of pings to send to each target (default 1)]:' \
   '-C n[same as -c, report results in verbose format]:' \
   '-e[show elapsed time on return packets]' \
   '-f[read list of targets from a file ( - means stdin)]:_file' \
   '-i n[interval between sending ping packets (in millisec) (default 25)]:' \
   '-l[loop sending pings forever]' \
   '-m[ping multiple interfaces on target host]' \
   '-n[show targets by name (-d is equivalent)]' \
   '-p n[interval between ping packets to one target (in millisec) (in looping and counting modes, default 1000)]:' \
   '-q[quiet (dont show per-target/per-ping results)]' \
   '-Q n[same as -q, but show summary every n seconds]:' \
   '-r n[number of retries (default 3)]:' \
   '-s[print final stats]' \
   '-t n[individual target initial timeout (in millisec) (default 500)]:' \
   '-u[show targets that are unreachable]'

_wanted hosts expl 'host name' _hosts