Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: rfc patch, abort rm instead of only removing the * from the cmdline

X-seq: zsh-users 13142
From: "Richard Hartmann" <richih.mailinglist@xxxxxxxxx>
To: "Mikael Magnusson" <mikachu@xxxxxxxxx>
Subject: Re: rfc patch, abort rm instead of only removing the * from the cmdline
Date: Sat, 16 Aug 2008 17:58:35 +0200
Cc: zsh-users <zsh-users@xxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=6hs6NvWeuSMSWUJPp0uXcnIVD+nh3Bao/E0iHR/4JcE=; b=k1h25s+l7dFuzzy/w7xvb3F+McP7E9SqF7/QY5hjXtNKYbfKmyztwuqGctLzgNHQo+ vpRwcbH7dvMndb6Dc7PbPWrS2SFjPAIDbbT5HeUP1MisHg5RGx/MBdhwmWpJI5TYepyg ZtFd0h4d6EaR5UWSHsMNugruqu0iHs0CVni9s=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=cnjvCCGmLEFEE5zwVap0XF1PwNX5Scg255g3wBm//yWV7peL3QzSb5zc4qM3sado4X GbAjfTct6ndqiPf+N7ERJ9GpplUrOuIdRW0A19jU8qCxWlT8O/kJyBDUTOGQC0UqlbxG 8VV1pDVVy1FKlHB78idm3PgFSswEMbxSAd2SM=
In-reply-to: <237967ef0808151649j1d14ce23s1acad02da98fdfdf@xxxxxxxxxxxxxx>
Mailing-list: contact zsh-users-help@xxxxxxxxxx; run by ezmlm
References: <237967ef0808151649j1d14ce23s1acad02da98fdfdf@xxxxxxxxxxxxxx>

On Sat, Aug 16, 2008 at 01:49, Mikael Magnusson <mikachu@xxxxxxxxx> wrote:

> % rm -rf * /tmp
> Before, even if you said no to the prompt, it will remove all your
> files in /tmp.

I am not quite sure what typo you want to catch? Maybe

  rm -rf */tmp

but I am not sure.

> -                   uremnode(args, node);
> +                   return;

Silently aborting on a valid syntax is always bad. As long as you
are in there, why not add a warning, informing the user of what
you are doing? Also, all new code should have comments, imo :)

Richard

Follow-Ups:
- Re: rfc patch, abort rm instead of only removing the * from the cmdline
  - From: Mikael Magnusson

References:
- rfc patch, abort rm instead of only removing the * from the cmdline
  - From: Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author