Re: Catch URLs (was: "Literal" command execution)

[Mark <lists+zsh@xxxxxxxxxxxxxx>]

Hi,

On Mon, 13 Feb 2012 12:57:59 +0000
Peter Stephenson <Peter.Stephenson@xxxxxxx> wrote:

> On Mon, 13 Feb 2012 12:38:55 +0000
> <mark+lists@xxxxxxxxxxxxxx> wrote:
> > url-quote-magic:68: array parameter reply created globally in
> > function url-quote-magic:72: array parameter reply created globally
> > in function
> 
> I don't think reply can be need outside url-quote-magic, can it?
> In fact, the function itself doesn't use it either --- ideally zstyle
> should have a mechanism for making it local within itself.
> 
> Index: Functions/Zle/url-quote-magic
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Functions/Zle/url-quote-magic,v
> retrieving revision 1.3
> diff -p -u -r1.3 url-quote-magic
> --- Functions/Zle/url-quote-magic	11 Jul 2008 19:12:24
> -0000	1.3 +++ Functions/Zle/url-quote-magic	13 Feb 2012
> 12:56:17 -0000 @@ -60,6 +60,7 @@
>  #       Use compsys for nested quoting analysis and command parsing.
>  
>  # Establish default values for styles, but only if not already set
> +local -a reply
>  
>  zstyle -m ':url-quote-magic:\*' url-metas '*' ||
>      zstyle ':url-quote-magic:*' url-metas '*?[]^(|)~#{}='
> 

Hmm, I have recently upgraded zsh and although I saw your patch
included, the error came back. Apparently I had fixed it manually.
Please see below. I wonder whether this method is ideal for you.

Thanks,
Mark

diff -pU1 old/url-quote-magic new/url-quote-magic 
--- old/url-quote-magic	2012-03-31 17:58:23.646634259 +0200
+++ new/url-quote-magic	2012-03-31 17:57:13.587013805 +0200
@@ -68,3 +68,3 @@ zstyle -m ':url-quote-magic:\*' url-meta
 zstyle -m ':url-quote-magic:\*' url-seps '*' ||
-    zstyle -e ':url-quote-magic:*' url-seps 'reply=(";&<>${histchars[1]}")'
+    zstyle -e ':url-quote-magic:*' url-seps 'local -a reply; reply=(";&<>${histchars[1]}")'
 
@@ -72,3 +72,3 @@ zstyle -m :url-quote-magic url-globbers
     zstyle -e :url-quote-magic url-globbers \
-	'zmodload -i zsh/parameter;
+	'local -a reply; zmodload -i zsh/parameter;
 	 reply=( noglob