Re: edit-command-line, vim, and pasting

[Oliver Kiddle <okiddle@xxxxxxxxxxx>]

Bart wrote:
> This is almost certainly yet another unexpected knock-on effect of the
> new bracketed-paste handling.

Indeed.

> We need a generalized fix for this.  Oliver?

I'm not sure we can do anything more generalized than the following
patch to edit-command-line. Perhaps the zle builtin could have an option
to cover the situation but that doesn't help much because the function
would still need to invoke the builtin. What did you have in mind?

This also changes the comments to suggest ! rather than v as the key for
edit-command-line (v overrides a default binding that was added since
edit-command-line was written: visual mode).

Oliver

diff --git a/Functions/Zle/edit-command-line b/Functions/Zle/edit-command-line
index 103a1c1..b814552 100644
--- a/Functions/Zle/edit-command-line
+++ b/Functions/Zle/edit-command-line
@@ -1,8 +1,8 @@
 # Edit the command line using your usual editor.
-# Binding this to 'v' in the vi command mode map,
+# Binding this to '!' in the vi command mode map,
 #   autoload -Uz edit-command-line
 #   zle -N edit-command-line
-#   bindkey -M vicmd v edit-command-line
+#   bindkey -M vicmd '!' edit-command-line
 # will give ksh-like behaviour for that key,
 # except that it will handle multi-line buffers properly.
 
@@ -10,7 +10,9 @@
   exec </dev/tty
 
   # Compute the cursor's position in bytes, not characters.
-  setopt localoptions nomultibyte
+  setopt localoptions nomultibyte noksharrays
+
+  (( $+zle_bracketed_paste )) && print -n $zle_bracketed_paste[2]
 
   # Open the editor, placing the cursor at the right place if we know how.
   local editor=${${VISUAL:-${EDITOR:-vi}}}
@@ -24,6 +26,8 @@
     (*) ${=editor} $1;;
   esac
 
+  (( $+zle_bracketed_paste )) && print -n $zle_bracketed_paste[1]
+
   # Replace the buffer with the editor output.
   print -Rz - "$(<$1)" 
 } =(<<<"$PREBUFFER$BUFFER")