Zsh Mailing List Archive
Messages sorted by:
Re: git-subtree completions
- X-seq: zsh-users 21557
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: Jordan Klassen <jordan@xxxxxxxxxxxxx>
- Subject: Re: git-subtree completions
- Date: Fri, 13 May 2016 02:39:52 -0700
- Cc: Zsh Users <zsh-users@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=gq3Sb5c7fpYZ6ts+FDFEqJJWJenp+srg7KK3RLDwFFc=; b=vFhOjOyLlwJk20GJkeTZrVncI4/Qo8qRIBQGpNr/G3PG7gqhSlkRhsCA85oOrT267z e6q433Q73x6Z3WiTUUqQYwZTOxVpWdWqmeemh63BvcjNkRiPpPge4pRYF81qvHGD5ARn ebdZB8cn3N69YRgr/H+ZsEhEvwCM3GpzenaCMdp7QVeZOynsmEkq1abfMTofG8B7yjzM 5nAiD7SRbT6c9pEi7PkyucBjVlkfDrRUndLd8mPNHnXIVpUe+kOlcKNK4EnFKz2nojO0 CfJGYC4OSEiGg8LuaHqFqMV46Pc0gxBfaUJWLdUuZ6pJJid4OX3SgvWDkMJH70XQAvzb qMRg==
- In-reply-to: <CAEsdBDkYMG6fopG9uAxXPZuDoOu5iW1QBBwM1r1-BCZ-iEtEpw@mail.gmail.com>
- List-help: <mailto:firstname.lastname@example.org>
- List-id: Zsh Users List <zsh-users.zsh.org>
- List-post: <mailto:email@example.com>
- Mailing-list: contact zsh-users-help@xxxxxxx; run by ezmlm
- References: <CAEsdBDkYMG6fopG9uAxXPZuDoOu5iW1QBBwM1r1-BCZ-iEtEpw@mail.gmail.com>
On Wed, May 11, 2016 at 10:57 PM, Jordan Klassen <jordan@xxxxxxxxxxxxx> wrote:
> I need feedback on it, and if it's better to submit a patch via `git
> send-email` let me know.
Generally speaking, yes, you should send a patch to zsh-workers.
> In particular, is there an easy way to test this
> without actually compiling zsh?
Since the diff is to a script file, yes. You just need to change the
$fpath array to list the directory containing your edited file ahead
of the directory containing the un-edited copy, before the first time
you attempt to complete after "git".
> How do I fix my `THIS_IS_A_HACK` issue?
I'm not sure what that's meant to accomplish? As far as I can tell
using a pattern that won't match anything should be the same as
leaving out the -A entirely.
> And code review in general.
There are others better qualified than me to critique changes to the
git completion ...
Messages sorted by: