Re: git-subtree completions

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Daniel Shahaf wrote on Thu, Jul 07, 2016 at 02:00:10 +0000:
> I see this has been committed now; reviewing the committed patch:
> 
> > +++ b/Completion/Unix/Command/_git
> > @@ -1747,6 +1747,91 @@ 
> > +            '(-m --message)'{-m,--message}'[use the given message as the commit message for the merge commit]' \
> 
> -m takes an argument, but this spec doesn't reflect that.  I assume it should be
> 
>                '(-m --message)'{-m+,--message=}'[use the given message as the commit message for the merge commit]:message' \
> 	                        ^^^ ^^^^^^^^^^                                                                    ^^^^^^^^
> (three changes)
> 
> > +            '(-P --prefix)'{-P,--prefix=}'[the path to the subtree in the repository to manipulate]: :_directories' \
> 
> s/-P,/-P+,/

I'll push a patch for these two in a minute (once I have the X-Seq of
this).

> > +            '--squash[import only a single commit from the subproject]' \
> > +            ': :__git_any_repositories_or_references' \
> > +            ':: :__git_ref_specs' && ret=0
> 
> __git_ref_specs doesn't seem appropriate here:
> .
>     % git subtree add -P foo ../other-repository/ master:target
>     'master:target' does not look like a ref

This issue is outstanding.

Cheers,

Daniel