Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: Zsh docker images
- X-seq: zsh-users 22829
- From: Julien Nicoulaud <julien.nicoulaud@xxxxxxxxx>
- To: "Nikolay Aleksandrovich Pavlov (ZyX)" <kp-pav@xxxxxxxxx>
- Subject: Re: Zsh docker images
- Date: Tue, 15 Aug 2017 12:53:09 +0200
- Cc: Mailing-list zsh-users <zsh-users@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Nm64LJBJ27i6b+GpTc9kvf5ZFnwTUrwEcUo5WIR/I2s=; b=OyzNLUQzO3XphEY3oaEi7WJzrB02zTv5uzPDFJJ2DJVolI2aW0JuQyQJxZdgYpeEhk vtz9GD7HHo1vSAKtEZvBWK+kBcEElINCx2LZ9sFJl/cvpP5RUkKbImzgDnqsgJonmkHX GJT2sCGpNrBD1q18nqGIq4zvA85sc07Aowx/4ZrfXB3pLJ/yzZsqMnDvEPoOAbbJH00y z+SwuTLfhGkancRiHx3mxWcjian3lW+AQDRRCLG+6XaaOH1kZcmq46B82qhNHm0kdgnI kRu+YIHdf3u8XTjRbjmI0T1YI/i6UMGevd4dHl6//VfAvDaqUzbr4y4Fr4XefXljhjqT vj/Q==
- In-reply-to: <191781502787229@web22g.yandex.ru>
- List-help: <mailto:zsh-users-help@zsh.org>
- List-id: Zsh Users List <zsh-users.zsh.org>
- List-post: <mailto:zsh-users@zsh.org>
- Mailing-list: contact zsh-users-help@xxxxxxx; run by ezmlm
- References: <CA+mcLN48bD4By2tjqPcu42hcF1JQg=boFuBCbGWvQqAgoZhSqw@mail.gmail.com> <368651502750468@web46j.yandex.ru> <CA+mcLN4r0NheQMNXjADinkN6fdkqXmJVfz9=k9sj4bjFvNUjnw@mail.gmail.com> <191781502787229@web22g.yandex.ru>
Thanks for the tips.
The solution you describe requires way more setup and maintainance than
what we have currently, so I prefer to keep things simple.
zsh-syntax-highlighting is a low activity project, we just need to make
sure tests run in acceptable time, and there is not too much adherence to
Travis-CI.
2017-08-15 10:53 GMT+02:00 Nikolay Aleksandrovich Pavlov (ZyX) <
kp-pav@xxxxxxxxx>:
>
>
> 15.08.2017, 02:19, "Julien Nicoulaud" <julien.nicoulaud@xxxxxxxxx>:
> > 2017-08-15 0:41 GMT+02:00 Nikolay Aleksandrovich Pavlov (ZyX) <
> > kp-pav@xxxxxxxxx>:
> >
> >> 15.08.2017, 01:12, "Julien Nicoulaud" <julien.nicoulaud@xxxxxxxxx>:
> >> > Hi all,
> >> >
> >> > I just wanted to advertise a small project that could be useful to
> other
> >> > zsh users: https://github.com/zsh-users/zsh-docker
> >> >
> >> > This builds images of many versions of zsh (including a daily build
> of
> >> > zsh's master branch) and deploys them to Docker Hub (
> >> > https://hub.docker.com/u/zshusers).
> >> >
> >> > So you can do, for instance:
> >> >
> >> > $ docker run -it zshusers/zsh-5.3.1
> >> >
> >> > -> will launch an interactive session of zsh 5.3.1
> >> >
> >> > We use it to automatically test zsh-syntax-highlighting on all
> supported
> >> > versions of zsh.
> >>
> >> What you could just as well do without docker which would make travis
> run
> >> faster due to not needed `sudo: required` and ability to setup travis
> >> cache. For testing something locally your docker images make more sense
> >> because they are easier to use then compiling that big amount of zsh
> >> versions.
> >
> > You mean, instead of using Docker, building the right zsh version on each
> > job and use Travis cache ? I am not sure that would work as we would have
> > to "make install" zsh anyway, so we would need sudo...
>
> 1. No, you may just build it with a bot and save an archive.
> https://github.com/powerline/bot-ci works like this for years, though I
> only have one zsh version. Binaries are in https://github.com/powerline/
> deps.
> 2. You need absolutely no `sudo` for `make install`. Just do user-local
> installation, something like ~/.local-zsh-$ZSH_VERSION. The *build bot* I
> referenced above is using container-based builds without sudo, not to
> mention powerline itself which it builds dependencies for. Works fine for
> CPython (some variant not provided by travis), zsh, zpython, tmux, fish, rc
> shell, libvterm, Vim, various Vim plugins and Python packages. This is only
> a matter of what you pass as a prefix.
> 3. Actually it is possible to build in the job itself and use travis
> cache, Neovim works this way. I found it more complicated to setup and it
> would make build times unpredictable for powerline since I do not hardcode
> versions like Neovim does.
>
> >
> > The Docker setup makes things very simple on zsh-syntax-highlighting
> side,
> > it's only one line (https://github.com/zsh-users/
> > zsh-syntax-highlighting/blob/master/.travis.yml#L30), so it stays clean
> and
> > it's easy to use on other projects as well.
> >
> >> Also why you have no builds for PRs
> >
> > All those PRs were submitted before we setup Travis-CI, I'm not sure if
> we
> > can trigger builds, maybe if contributors rebase their branches ?
> >
> >> and why you don’t merge those 24 jobs into something like 7 (4.3*,
> 5.0*,
> >> 5.1*, 5.2*, 5.3*, 5.4*, master)? Less then twenty seconds to run tests
> in a
> >> single job, lots of time to initialize VMs and there is nothing which
> may
> >> prevent you from consequently running two docker commands in one job,
> or
> >> using two zsh versions via other means.
> >
> > Yeah sure, it was just easier to setup and to get a dashboard with every
> > version. We want to make it easy for contributors what their pull request
> > broke. If we start grouping jobs, log files will be harder to analyse.
> >
> > Currently build time is 5/6 minutes, so I don't see it as a big issue.
>
> Travis has folds, so you may create a fold for each version and print a
> summary of “what failed” below for contributors to know what to unfold. (Of
> course, this works in web interface only.) See https://github.com/ZyX-I/
> neovim/blob/663ca27d3ac9567bb82fc66141aae67bd80190d2/ci/common/suite.sh
> for an example, though I must say I have not set up `set [+-]x` well, so
> some trace lines appear outside folds.
>
> >
> >> >
> >> > Cheers,
> >> > Julien
>
Messages sorted by:
Reverse Date,
Date,
Thread,
Author