Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: edit-command-line breaks out of vared
- X-seq: zsh-users 23591
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: zsh-users@xxxxxxx
- Subject: Re: edit-command-line breaks out of vared
- Date: Mon, 20 Aug 2018 12:58:32 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=uktvUV EAeTIuZJxQ368Im33APoqyQSK5GdBr5AKyO0M=; b=nx0iy4D5l6AMjmMdBx856l vqxd4H+7SyRZANv26SxrrEjOB4Sb0Ex5/PMLkJsBN63rrY48htl5nOdlCMLFNzIF dQN9evoQQ2EowXLCnlgrOMPldEBWDhfwPAZttifB3eL693Dq65bu2dxejtkEXu9U DQa7jVzLy5hi8SohufsJnYQN0BcJqvfltWcbtThhZSaSbYq6xMN0mW9GbHKv7qI+ dSop7nnrht6kjL2rYXlILWHWoxSxD6/fdOJj67BnhyKF6wnCxy7q9cY9kihRmLyO opxwCTWLqAfjA82kPGV3zZSMhlccqwnwA22eUn3O3MRSzxK22Ix4VCLltSMgtZVg ==
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=uktvUV EAeTIuZJxQ368Im33APoqyQSK5GdBr5AKyO0M=; b=fDgumMHAhE1aq1J5AFyRFI UZ+NxRaH/bl1hWo2cKHvf2W0rNguuB4kz4tWSlX/qlo3uyX86uXnX3NiSlYL9nfB +3/rih2f1Gjvt5q2oBhAbWRXq6WO67eX5kJtzk/jZqV8qFIfMl1Q5yNFf+KWREos k9wusXfnBDC3U+yopTplH13qxIsHgKAg1ioM4cXedZDykI+qCzuqY1JXp6/YXkB7 WISGDsDhmDUwjrQF7dwZw8KHGAcB48l8Pt8kZDqmHoQOza8GdmeXkwGQT5HizZ1I v3StG9VdC84Mez4tpPosU0UURp4xidTqA+mKMrB+fmSsn3qYUGiRa06NABXxnITw ==
- In-reply-to: <CAH+w=7aL3yswgM36XU_ehwa5ppH0zXw4qxCgCLiOwKRBH3XbnA@mail.gmail.com>
- List-help: <mailto:zsh-users-help@zsh.org>
- List-id: Zsh Users List <zsh-users.zsh.org>
- List-post: <mailto:zsh-users@zsh.org>
- List-unsubscribe: <mailto:zsh-users-unsubscribe@zsh.org>
- Mailing-list: contact zsh-users-help@xxxxxxx; run by ezmlm
- References: <20180819122254.mgx2kfbnbsxxtuqk@tarpaulin.shahaf.local2> <CAHYJk3RBurSZJuFdzua5DPAU7rd2wvZX6tSAEtAXwD89-Fd_NQ@mail.gmail.com> <CAH+w=7aL3yswgM36XU_ehwa5ppH0zXw4qxCgCLiOwKRBH3XbnA@mail.gmail.com>
Bart Schaefer wrote on Sun, 19 Aug 2018 12:03 -0700:
> > On Sun, Aug 19, 2018 at 2:22 PM, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> >>
> >> I expected quitting the editor to let me resume the vared session
>
> My first inclination here is to ask why you expected that ...
>
> >> instead it left me with the variable's value as a command line.
>
> ... because the name of the function is edit-command-line, after all.
>
I assumed edit-command-line would work inside vared, despite the
name, and that when $EDITOR finished it would return me to the
previous context.
> On Sun, Aug 19, 2018 at 6:18 AM, Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
> > This works in my version of edit-command-line,
> >
> > + [[ -z $PREBUFFER ]] && {
>
> Hrm, is PREBUFFER really guaranteed to be empty whenever vared is
> running? I suppose so.
Is there a reason not to commit that? Before we might've thought it was only
an optimisation but now it seems to enable behaviour that isn't possible with
the code in HEAD. I don't see anything in my archives about reasons not to
commit that.
Cheers,
Daniel
Messages sorted by:
Reverse Date,
Date,
Thread,
Author