Re: No fsync on history file? I lost my history

[lilydjwg <lilydjwg@xxxxxxxxx>]

On Sun, Sep 23, 2018 at 01:35:47PM +0000, Daniel Shahaf wrote:
> lilydjwg wrote on Sun, 23 Sep 2018 16:52 +0800:
> > Would you add the fsync call or make an option for that?
> 
> I'd be happy to accept patches for this.

Here it is. I've checked that it works on my Linux system, but not sure
about other systems.

-- 
Best regards,
lilydjwg

From 78b1df1329b2c7bb2b6e78e5b7d70be4bbf103e2 Mon Sep 17 00:00:00 2001
From: lilydjwg <lilydjwg@xxxxxxxxx>
Date: Sun, 23 Sep 2018 22:12:56 +0800
Subject: [PATCH] Call fsync after writing out new histfile

to ensure the data is on disk before the rename in case of a system crash.
---
 Src/hist.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Src/hist.c b/Src/hist.c
index dbdc1e4e5..e128e9f14 100644
--- a/Src/hist.c
+++ b/Src/hist.c
@@ -2933,6 +2933,9 @@ savehistfile(char *fn, int err, int writeflags)
 		lasthist.text = ztrdup(start);
 	    }
 	}
+	fflush(out); /* need to flush before fsync */
+	if (fsync(fileno(out)) < 0 && ret >= 0)
+	    ret = -1;
 	if (fclose(out) < 0 && ret >= 0)
 	    ret = -1;
 	if (ret >= 0) {
-- 
2.19.0