Re: [PATCH] improve surfraw subcommands list

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Marc Chantreux wrote on Sat, Feb 27, 2021 at 16:27:35 +0100:
> diff --git a/Completion/Unix/Command/_surfraw b/Completion/Unix/Command/_surfraw
> index f945f1ca9..343d275cc 100644
> --- a/Completion/Unix/Command/_surfraw
> +++ b/Completion/Unix/Command/_surfraw
> @@ -424,12 +424,26 @@ case $state in
>        yubnub)
>          _message -e command 'Yubnub Command'
>        ;;
> +      *)
> +        _message -e string 'search string'
> +      ;;
>      esac
>    ;;
>    elvi)
> +    local -UT XDG_CONFIG_DIRS xcd

Don't play golf.  Name it «xdg_config_dirs».

> +    # as it starts with a space, the header becomes an empty
> +    # string removed by the list expansion

What?  Does "the header" mean the first line of the output?

>      _wanted elvi expl elvi compadd \
> -      ${${${(f)"$(_call_program elvi surfraw -elvi)"}%%[[:space:]]##--*}%:*} && ret=0
> +        ${${(f)"$(surfraw -elvi)"}%%[[:space:]]*} $(

Restore _call_program.

> +          # extract the keys of all bookmarks (should be in surfraw itself)
> +          awk '{keys[$1]=1} END {for (k in keys) print k}' \

Use a parameter expansion rather than an external dependency and a fork,
if possible.  If there's a reason to make an exception, it's not clear
to me.

> +          $^xcd/surfraw/bookmarks(Nr) \
> +          /etc/xdg/surfraw/bookmarks(Nr) \
> +          /etc/surfraw.bookmarks(Nr) \
> +          ${XDG_CONFIG_HOME-${HOME?homeless}/.config}/surfraw/bookmarks(Nr) \
> +          ${HOME?homeless}/.surfraw.bookmarks(Nr)

There shouldn't be an error message here at all, certainly not such
a brief one.

> 

Please use proper capitalization in your written English.

> +        ) && ret=0
>    ;;
> -esac  
> +esac
>  
>  return ret