Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Duplicate results in _python - (Re: [MINOR BUG] Duplicate results in tab-menu)

X-seq: zsh-users 27894
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Zsh Users <zsh-users@xxxxxxx>
Cc: Eric Cook <llua@xxxxxxx>, Dan Arad <dan1994@xxxxxxxxx>
Subject: Re: Duplicate results in _python - (Re: [MINOR BUG] Duplicate results in tab-menu)
Date: Sat, 16 Jul 2022 20:48:51 -0700
Archived-at: <https://zsh.org/users/27894>
In-reply-to: <CAH+w=7YMMDPTTBiVshGuG0_2fO0hU5Twf23Qcw-eRg_FJrFrcg@mail.gmail.com>
List-id: <zsh-users.zsh.org>
References: <CAGS3e0adVWdp3p7cbjkvH84P6PL7-G2YzcAcu2zq435n+mLk9Q@mail.gmail.com> <0c939d76-d9ff-e684-cbc5-70dac285491d@gmx.com> <CAH+w=7YMMDPTTBiVshGuG0_2fO0hU5Twf23Qcw-eRg_FJrFrcg@mail.gmail.com>

On Thu, Jun 23, 2022 at 10:41 PM Bart Schaefer
<schaefer@xxxxxxxxxxxxxxxx> wrote:
>
> The trouble here is that the completion invoked by _dispatch is
> explicitly allowed to change _compskip to control the behavior of
> _dispatch.  It just happens that any completion that relies on calling
> _normal may do so incorrectly.
>
> [...]  So the fix appears to be to make _compskip local to
> _python, which seems a bit icky because it doesn't help with any other
> completions that may have it wrong.  Better suggestions?

As there's been no follow-up, and this also appears to address issues
raised in https://zsh.org/workers/45767, I'm going to go ahead and
commit the change to _python.

References:
- [MINOR BUG] Duplicate results in tab-menu
  - From: Morten Nissov
- Duplicate results in _python - (Re: [MINOR BUG] Duplicate results in tab-menu)
  - From: Eric Cook
- Re: Duplicate results in _python - (Re: [MINOR BUG] Duplicate results in tab-menu)
  - From: Bart Schaefer

Messages sorted by: Reverse Date, Date, Thread, Author