Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: zle_refresh patch 2
- X-seq: zsh-workers 2959
- From: "Bart Schaefer" <schaefer@xxxxxxxxxxxxxxxxxxxxxxx>
- To: <hzoli@xxxxxxxxxxxx> (Zoltan T. Hidvegi)
- Subject: Re: zle_refresh patch 2
- Date: Wed, 5 Mar 1997 16:51:10 -0800
- Cc: zsh-workers@xxxxxxxxxxxxxxx (Zsh workers list)
- In-reply-to: <hzoli@xxxxxxxxxxxx> (Zoltan T. Hidvegi) "Re: zle_refresh patch 2" (Mar 5, 6:47pm)
- References: <9703052347.AA20952@xxxxxxxxxxxxxxxxxxxxxx>
- Reply-to: schaefer@xxxxxxx
On Mar 5, 6:47pm, (Zoltan T. Hidvegi) wrote:
} Subject: Re: zle_refresh patch 2
}
} Fine, but there are two problems: shortterm is a zle variable and in 3.1
} utils.c has no access to zle globals.
It's only mentioned in a DPUTS anyway; just scrap the DPUTS in 3.1 (as
you did). Geoff's original patch did more with it than that.
} The other problem is that
} resetneeded local variable has the same name as a global one, which is
} misleading. Also a comparision should use >= 3 instead on > 3. I simply
} removed the resetneeded variable, since it was really unnecessary.
Hmm. Well, I dislike your change because it presumes that init_term()
is independent of the values of "lines" and "columns". This in itself
(init_term() not knowing about lines/columns) MAY be wrong, now that I
look at it, because init_term() is called from zle in a couple places,
namely putprompt() and zleread().
Will zle ever call init_term in such a way that a very-small terminal is
set incorrectly? I don't follow it well enough to be sure.
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.nbn.com/people/lantern
Messages sorted by:
Reverse Date,
Date,
Thread,
Author