Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

PATCH: glob coredump fix



% ./zsh -f
% setopt extendedglob
% echo ((#))
zsh: bad pattern: ((#))
% echo *.c
zsh: 1779 segmentation fault (core dumped)  ./zsh -f

tail was assumed to be always NULL when pattern parsing was called.

3.0.5 already has this fix.  There were significant changes in glob.c
since 3.1.2, but this patch still seems to work.

Zoli


*** Src/glob.c.orig	Sat May  9 15:02:46 1998
--- Src/glob.c	Sat May  9 15:06:05 1998
*************** struct comp {
*** 125,131 ****
  #define GF_TOPLEV	2	/* outside (), so ~ ends main match */
  
  static char *pptr;		/* current place in string being matched */
! static Comp tail = 0;
  static int first;		/* are leading dots special? */
  
  /**/
--- 125,131 ----
  #define GF_TOPLEV	2	/* outside (), so ~ ends main match */
  
  static char *pptr;		/* current place in string being matched */
! static Comp tail;
  static int first;		/* are leading dots special? */
  
  /**/
*************** parsepat(char *str)
*** 802,807 ****
--- 802,808 ----
  {
      mode = 0;			/* path components present */
      pptr = str;
+     tail = NULL;
      return parsecomplist();
  }
  
*************** parsereg(char *str)
*** 2434,2439 ****
--- 2435,2441 ----
      remnulargs(str);
      mode = 1;			/* no path components */
      pptr = str;
+     tail = NULL;
      return parsecompsw(GF_TOPLEV);
  }
  



Messages sorted by: Reverse Date, Date, Thread, Author