Re: PATCH: some minor fixes for zle_hist.c (3.1.4)

["Bart Schaefer" <schaefer@xxxxxxxxxxxxxxxx>]

On Jun 10,  3:56am, Wayne Davison wrote:
} Subject: PATCH: some minor fixes for zle_hist.c (3.1.4)
}
} I've fixed a couple minor bugs in zle_hist.c in 3.1.4:
} 
}  + The up-line and down-line code was duplicated in multiple spots
}    in zle_hist.c, and among the different versions there was one
}    inconsistency which I believe is a bug.

I'm staring at this code and I've come to the conclusion that if it
works the same as the old code, then the old code had more bugs than
Wayne fixed.

I would have expected zmult to indicate how many previous occurrences
of the first word on the current line to search through. However,
historysearchbackward() ignores zmult entirely, and uplineorsearch()
attempts to move up zmult lines (and reduces zmult by the number of
lines it moved) -before- beginning the search ...

So a multiplier on up-line-or-search means "move up N lines in the edit
buffer, or if you can't move N lines, then search the history for the
first word on the first line in the edit buffer."

Does that seem as useless to anyone else as it does to me?

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com