Re: another bug in suffix removal 3.1.5

[Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>]

Peter Stephenson wrote:

> 
> Sven Wischnowsky wrote:
> > greg@xxxxxxxxxxxxx wrote:
> > 
> > > OK, I found another one:
> > > 
> > > % mkdir foo
> > > % mkdir foo/bar
> > > % bar <Control-a> <Control-k>   # IE, get "bar" in the kill ring
> > > % ls f <tab>
> > >   -> foo/ <Control-y>
> > >   -> foobar                     # the slash got removed when "bar" was yank
> > ed
> > 
> > No patch for this now (I have to go soon), but this looks like yet
> > another missing fixsuffix() problem.
> 
> Isn't it just a case of adding ZLE_KEEPSUFFIX to the flags for yank?
> The following would be my suggestion.  Seems to work.

Probably depends on what behavior you like if there is nothing to
yank. Without your patch, the suffix is removed which is certainly
wrong. With your patch the suffix is kept and made non-auto-removable.
Personally I would prefer zsh to leave the suffix on the line and
automatically removable in whenever a zle widget doesn't change the
line and cursor position. But maybe I'm the only one who would prefer
that.


Bye
 Sven


--
Sven Wischnowsky                         wischnow@xxxxxxxxxxxxxxxxxxxxxxx