Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: 3.1.5-pws-5++: typeset -T fixlet



On Jan 30,  2:16pm, Peter Stephenson wrote:
} Subject: PATCH: 3.1.5-pws-5++: typeset -T fixlet
}
} --- Src/params.c.tied2	Fri Jan 29 17:36:10 1999
} +++ Src/params.c	Sat Jan 30 14:02:11 1999
} @@ -1501,7 +1501,7 @@
}  	if (!(v = getvalue(&s, 1)))
}  	    createparam(t, PM_SCALAR);
}  	else if (PM_TYPE(v->pm->flags) == PM_ARRAY &&
} -		 !(v->pm->flags & PM_SPECIAL) && unset(KSHARRAYS)) {
} +		 !(v->pm->flags & (PM_SPECIAL|PM_TIED)) && unset(KSHARRAYS)) {
}  	    unsetparam(t);
}  	    createparam(t, PM_SCALAR);
}  	    v = NULL;

This hunk failed for me because Peter's copy of the source STILL doesn't
have the change from

 	else if (PM_TYPE(v->pm->flags) == PM_ARRAY &&
to
 	else if ((PM_TYPE(v->pm->flags) & (PM_ARRAY|PM_HASHED)) &&

Peter, is there some reason you keep leaving this out?  I keep sending
patches for it every time you do another -pws-N release, but it never
makes it into your source code.  If it'd be wrong for some reason, I'd
sure like to know why.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com



Messages sorted by: Reverse Date, Date, Thread, Author