Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: Re: history curiosities

X-seq: zsh-workers 7204
From: Peter Stephenson <pws@xxxxxxxxxxxxxxxxx>
To: zsh-workers@xxxxxxxxxxxxxx (Zsh hackers list)
Subject: Re: PATCH: Re: history curiosities
Date: Mon, 19 Jul 1999 17:51:43 +0200
In-reply-to: "Peter Stephenson"'s message of "Sun, 18 Jul 1999 16:59:28 DFT." <9907181459.AA12423@xxxxxxxxxxxxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxxxxxx; run by ezmlm

Peter Stephenson wrote:
> The second is presumably new, and is a bit harder; I only discovered it
> because of the first one.  In remhist(), the hist_ring is freed under the
> circumstances I'm talking about (a history command with HISTNOSTORE), but
> is not set to NULL, so is referred to again with the next hbegin().

Looks like a false alarm, on closer examination.  freehistnode() does
indeed free the hist_ring that was around before, but freehistdata() has
already unlinked it from the ring and set hist_ring to something else as a
side effect.  So there's nothing wrong.

-- 
Peter Stephenson <pws@xxxxxxxxxxxxxxxxx>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy

References:
- PATCH: Re: history curiosities
  - From: Peter Stephenson

Messages sorted by: Reverse Date, Date, Thread, Author