Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

PATCH: 3.1.6-pws-4: zftp idiocies

X-seq: zsh-workers 7836
From: Peter Stephenson <pws@xxxxxxxxxxxxxxxxx>
To: zsh-workers@xxxxxxxxxxxxxx (Zsh hackers list)
Subject: PATCH: 3.1.6-pws-4: zftp idiocies
Date: Wed, 15 Sep 1999 10:33:31 +0200
Mailing-list: contact zsh-workers-help@xxxxxxxxxxxxxx; run by ezmlm

Quite by coincidence, two of the most stupid bugs ever introduced into an
FTP client appear in the zftp rmsession command.

--- Src/Modules/zftp.c.stupid	Fri Sep 10 11:57:43 1999
+++ Src/Modules/zftp.c	Wed Sep 15 10:30:32 1999
@@ -2772,7 +2772,7 @@
     char *newsess = NULL;
 
     /* Find the session in the list: either the current one, or by name */
-    for (no = 0, nptr = firstnode(zfsessions); nptr; no++, nptr++) {
+    for (no = 0, nptr = firstnode(zfsessions); nptr; no++, incnode(nptr)) {
 	sptr = (Zftp_session) nptr->dat;
 	if ((!*args && sptr == zfsess) ||
 	    (*args && !strcmp(sptr->name, *args)))
@@ -2794,7 +2794,7 @@
 	    LinkNode newn = firstnode(zfsessions);
 	    if (newn == nptr)
 		incnode(newn);
-	    newsess = ((Zftp_session)nptr->dat)->name;
+	    newsess = ((Zftp_session)newn->dat)->name;
 	}
     } else {
 	Zftp_session oldsess = zfsess;

-- 
Peter Stephenson <pws@xxxxxxxxxxxxxxxxx>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy

Messages sorted by: Reverse Date, Date, Thread, Author