PATCH: Re: BUG: coredump with menu-select and LIST_PACKED

[Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>]

Bart Schaefer wrote:

> The instructions that Alexandre gave were exactly what I did to produce
> the stack trace.

I finally had the idea that `M-m' was bound to `menu-select' and after 
a bit of trying, I finally could reproduce it. The problem was that
the data wasn't re-calculated when the new list of matches was
generated.

But before I found that, I found another problem with menu-select --
there still was a reference to `ZLS_SELECT'. I have no idea how this
survived.


Bye
 Sven

diff -u os/Zle/complist.c Src/Zle/complist.c
--- os/Zle/complist.c	Tue Oct 26 13:11:00 1999
+++ Src/Zle/complist.c	Wed Oct 27 09:56:50 1999
@@ -251,6 +251,7 @@
 /* Information about the list shown. */
 
 static int noselect, mselect, inselect, mcol, mline, mcols, mlines, mmlen;
+static int selected;
 static Cmatch **mtab, **mmtabp;
 static Cmgroup *mgtab, *mgtabp;
 static struct listcols mcolors;
@@ -567,6 +568,7 @@
 	    inselect = 1;
 	    if (noselect)
 		break;
+	    selected = 1;
 	    if (!i) {
 		i = mcols * mlines;
 		while (i--)
@@ -876,8 +878,9 @@
     int d = 0;
 
     if (!minfo.cur) {
+	selected = 0;
 	menucomplete(args);
-	if ((minfo.cur && minfo.asked == 2) || getsparam("ZLS_SELECT"))
+	if ((minfo.cur && minfo.asked == 2) || selected)
 	    return 0;
 	d = 1;
     }
diff -u os/Zle/zle_tricky.c Src/Zle/zle_tricky.c
--- os/Zle/zle_tricky.c	Tue Oct 26 13:11:01 1999
+++ Src/Zle/zle_tricky.c	Wed Oct 27 10:14:21 1999
@@ -5915,6 +5915,7 @@
     hasperm = 1;
     permmnum = mn - 1;
     permgnum = gn - 1;
+    listdat.valid = 0;
 
     return fi;
 }

--
Sven Wischnowsky                         wischnow@xxxxxxxxxxxxxxxxxxxxxxx