Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: _value

X-seq: zsh-workers 8488
From: Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>
To: zsh-workers@xxxxxxxxxxxxxx
Subject: Re: PATCH: _value
Date: Tue, 2 Nov 1999 14:00:13 +0100 (MET)
In-reply-to: Tanaka Akira's message of 02 Nov 1999 21:50:41 +0900
Mailing-list: contact zsh-workers-help@xxxxxxxxxxxxxx; run by ezmlm

Tanaka Akira wrote:

> I wrote _value to complete values for parameter assignments.
> 
> And I found a problem with this.  When I try the completion by _value
> first time, it is failed and "funcstack wrapper with wrong function"
> is displayed.  Since second time, there is no problem.

And thus the parameter module revealed a bug in the function calling
code: it didn't dup the name and when the function was re-defined, the 
name in use by the wrappers was freed.

Bye
 Sven

--- oldsrc/exec.c	Mon Nov  1 09:03:16 1999
+++ Src/exec.c	Tue Nov  2 13:57:30 1999
@@ -3018,7 +3018,7 @@
 		argzero = ztrdup(argzero);
 	    }
 	}
-	runshfunc(list, wrappers, name);
+	runshfunc(list, wrappers, dupstring(name));
 	if (retflag) {
 	    retflag = 0;
 	    breaks = obreaks;

--
Sven Wischnowsky                         wischnow@xxxxxxxxxxxxxxxxxxxxxxx

Follow-Ups:
- Re: PATCH: _value
  - From: Tanaka Akira

Messages sorted by: Reverse Date, Date, Thread, Author