Re: PATCH: tcsetpgrp test switch

["Bart Schaefer" <schaefer@xxxxxxxxxxxxxxxxxxxxxxx>]

On Nov 2,  3:10pm, Clint Adams wrote:
} Subject: PATCH: tcsetpgrp test switch
}
} This provides a configure switch to prevent the testing of tcsetpgrp.

There doesn't seem to be much point in performing this test at all when
it can't possibly succeed.  Rather than a command-line switch, why not:

Index: configure.in
===================================================================
@@ -1233,7 +1233,7 @@
 dnl if found tcsetpgrp, test to see if it actually works
 dnl for instance, BeOS R4.51 does not support it yet
 dnl -----------
-if test $ac_cv_func_tcsetpgrp=yes; then
+if test -t 0 -a $ac_cv_func_tcsetpgrp=yes; then
     AC_CACHE_CHECK(if tcsetpgrp() actually works,
     zsh_cv_sys_tcsetpgrp,
     [AC_TRY_RUN([


One reason "why not" may be that it's better to err on the side of no job
control rather than broken job control; but perhaps in that case we should
try something more clever -- such as, build in the job control functions
but default the state of the option to NO_MONITOR.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com