Re: PATCH: _diff (new), _prcs (upgrade)

[Alexandre Duret-Lutz <duret_g@xxxxxxxx>]

>>> "Sven" == Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx> writes:

 Sven> Alexandre Duret-Lutz wrote:

[...]

 Sven> Oh, and it makes _diff_options use `$(command diff ...)' -- I at least 
 Sven> have a small wrapper function for it which makes it fail otherwise.
 >> 
 >> I first wrote this, and then removed 'command' when I thought that on a
 >> system without GNU diff a user may have installed GNU diff and made diff be
 >> an alias to GNU diff.  But maybe it's quite uncommon especially with diff
 >> (which is used by several commands and is thus better put in the PATH).
 >> 
 >> Also, I should say: I understand why _pids is running $(command ps ...)
 >> but the difference in _diff_options is that we should be testing the
 >> command that the user is actually running.

I rethought about it this morning, and while I have not changed my idea, I
can describe it differently.  My opinion is: we should write $(XXX) if
we are in the completion function for XXX, and $(command XXX) otherwise.
In the former case, we really need to see what the user is actually running,
in order to not complete for the wrong command (that's the case in _diff,
I think); in the later case we need to call a command directly in order
to get unaltered result (case of the call to ps in _pids).

 Sven> Actually, I wasn't too sure about _pids either... the problem is that
 Sven> some users may have functions for ps, diff, and so on that may give
 Sven> completely different results when invoked in the way we invoke them.

 Sven> Hm. maybe we should try to solve this in a generic manner by writing a 
 Sven> function that is called in such cases, like:

 Sven>   _call <name> [ <how> ]

 Sven> (i.e. we use `$(_diff ps)', `$(_call ps list)' and so on).

$(_call diff version)?

 Sven> _call would then first see if there is a style `command-line' for the
 Sven> tag `<name>' or, if <how> is given, <name>-<how>. If there is such a
 Sven> style it is used as an array containing the whole command line to use
 Sven> (the styles for ps we have now would be removed). 

 Sven> If there is no such style, and $+functions[<name>] is 1, we use
 Sven> `command <name>', otherwise we use just `<name>'.

I'm not sure to understand this default behaviour, what would be
the default for a <name>-<how> call? (where will arguments come
from?).


  $(diff -v </dev/null)

would be replaced by

  $(_call diff version)

with something like

 zstyle '*:diff-version' command-line 'diff -v </dev/null'

where is this last line going to be?  will every completion function
have to pollute compinit to set such default?


Another point about the $+functions[<name>] test: what if I am writting a
completion function for a shell function? say I need to call it, how do I
do?

[...]

-- 
Alexandre Duret-Lutz