Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
PATCH: RE: undo does not work in menu-selection
- X-seq: zsh-workers 11992
- From: Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxxxxxxxxx
- Subject: PATCH: RE: undo does not work in menu-selection
- Date: Mon, 19 Jun 2000 16:48:42 +0200 (MET DST)
- In-reply-to: "Andrej Borsenkow"'s message of Mon, 19 Jun 2000 14:56:58 +0400
- Mailing-list: contact zsh-workers-help@xxxxxxxxxxxxxx; run by ezmlm
Andrej Borsenkow wrote:
> > Err? What should it undo? And keep in mind that undo has this
> > possibility to go up and resume completing in menu-selection.
> >
> > Hm, or make it leave selection when at the `top-level'?
>
> This looks natural. And it is really confusing, when undo just does
> nothing at all.
>
> > But you have noticed how ^G behaves in menu-selection, yes?
> >
>
> Ehem ... sorry, yes. Still, it is better when a widget (undo in this
> case) has consistent behaviour. In this case, action is to start
> menu-selection - so "undone" action is to leave menu-selection?
I could convince myself... or does anyone object?
Bye
Sven
Index: Src/Zle/complist.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/complist.c,v
retrieving revision 1.27
diff -u -r1.27 complist.c
--- Src/Zle/complist.c 2000/06/14 06:54:45 1.27
+++ Src/Zle/complist.c 2000/06/19 14:48:08
@@ -1852,7 +1852,7 @@
int l;
if (!u)
- goto getk;
+ break;
cs = 0;
foredel(ll);
--
Sven Wischnowsky wischnow@xxxxxxxxxxxxxxxxxxxxxxx
Messages sorted by:
Reverse Date,
Date,
Thread,
Author