Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

PATCH: Re: segfault with _rpm completion

X-seq: zsh-workers 12066
From: Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>
To: zsh-workers@xxxxxxxxxxxxxx
Subject: PATCH: Re: segfault with _rpm completion
Date: Mon, 26 Jun 2000 10:09:30 +0200 (MET DST)
In-reply-to: Adam Spiers's message of Mon, 26 Jun 2000 02:37:32 +0100
Mailing-list: contact zsh-workers-help@xxxxxxxxxxxxxx; run by ezmlm

Adam Spiers wrote:

> Latest cvs zsh dumps core after
> 
>   $ zsh -f
>   $ autoload compinit; compinit
>   $ rpm -qf /<TAB>

Missing allocation for the option-argument list. Ouch.

Bye
 Sven

Index: Src/Zle/computil.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/computil.c,v
retrieving revision 1.34
diff -u -r1.34 computil.c
--- Src/Zle/computil.c	2000/06/22 08:42:37	1.34
+++ Src/Zle/computil.c	2000/06/26 08:08:53
@@ -1349,6 +1349,8 @@
 		state.argend = argend;
 		doff = state.doff = 0;
 		state.singles = 1;
+		if (!state.oargs[state.curopt->num])
+		    state.oargs[state.curopt->num] = znewlinklist();
 		goto cont;
 	    } else {
 		state.curopt = NULL;
@@ -1422,6 +1424,9 @@
 
 	    if (sopts && nonempty(sopts))
 		state.curopt = (Caopt) uremnode(sopts, firstnode(sopts));
+
+	    if (!state.oargs[state.curopt->num])
+		state.oargs[state.curopt->num] = znewlinklist();
 
 	    ddef = state.def = state.curopt->args;
 	    dopt = state.curopt;

--
Sven Wischnowsky                         wischnow@xxxxxxxxxxxxxxxxxxxxxxx

Messages sorted by: Reverse Date, Date, Thread, Author