Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: zrealpath

X-seq: zsh-workers 12544
From: Clint Adams <schizo@xxxxxxxxxx>
To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: PATCH: zrealpath
Date: Sat, 5 Aug 2000 00:13:22 -0400
Cc: zsh-workers@xxxxxxxxxxxxxx
In-reply-to: <1000805022858.ZM29168@xxxxxxxxxxxxxxxxxxxxxxx>; from schaefer@xxxxxxxxxxxxxxxxxxxxxxx on Sat, Aug 05, 2000 at 02:28:58AM +0000
Mailing-list: contact zsh-workers-help@xxxxxxxxxxxxxx; run by ezmlm
References: <20000804212746.A8137@xxxxxxxx> <1000805022455.ZM29144@xxxxxxxxxxxxxxxxxxxxxxx> <1000805022858.ZM29168@xxxxxxxxxxxxxxxxxxxxxxx>

> } This wasn't necessary; it's what utils.c:xsymlink() is for.
> 
> Oh, and xsymlink() needs to call readlink(), which brings us full circle.

We could move xsymlink() and friend to the #else part of zrealpath,
have param.c call that instead, and dynamically allocate buffers according
to zpathmax, which can't ever call zrealpath.

Actually, what I said about checking the last character for a null
is silly; all you need to do is compare the return value of readlink()
with the buffer size.  That's not so messy.

References:
- PATCH: zrealpath
  - From: Clint Adams
- Re: PATCH: zrealpath
  - From: Bart Schaefer
- Re: PATCH: zrealpath
  - From: Bart Schaefer

Messages sorted by: Reverse Date, Date, Thread, Author