Re: PATCH: RE: Trivial patches for FreeBSD

[Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>]

Bart Schaefer wrote:

> On Sep 7, 10:38am, Sven Wischnowsky wrote:
> } 
> } Andrej Borsenkow wrote:
> } 
> } > compadd "$@" - /boot/kernel/*.ko(N:t) /modules/*.ko(N:t) && ret=0
> } 
> } That sounds reasonable. I've changed in some other places, too (anyone 
> } who uses _mailboxes please check my work there).
> 
> Looks OK, but:
> 
> Is there EVER a case where we want the completion system to fail with a
> "no match" error, or to return a glob pattern instead of an actual file
> name?
> 
> Maybe _main_complete should setopt nullglob nocshnullglob and have done
> with it.

Interestingly, in _main_complete:19 we see:

  setopt localoptions nullglob ...

And it seems to have been there for quite some time. Maybe we (ok, I)
got confused because in some places we use the foo(N) trick to turn a
normal string into a pattern to avoid having to explicitly test for
the existence of files searched.

But since cshnullglob overrides nullglob, we should probably unset
that in _main_complete, as Bart suggests...

Bye
 Sven

Index: Completion/Core/_main_complete
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Core/_main_complete,v
retrieving revision 1.40
diff -u -r1.40 _main_complete
--- Completion/Core/_main_complete	2000/08/03 13:35:44	1.40
+++ Completion/Core/_main_complete	2000/10/05 13:30:51
@@ -16,8 +16,8 @@
 # which makes the output of setopt and unsetopt reflect a different
 # state than the global one for which you are completing.
 
-setopt localoptions nullglob rcexpandparam extendedglob noshglob
-unsetopt markdirs globsubst shwordsplit nounset ksharrays
+setopt localoptions nullglob rcexpandparam extendedglob noshglob \
+       nomarkdirs noglobsubst noshwordsplit unset noksharrays nocshnullglob
 exec </dev/null	# ZLE closes stdin, which can cause errors
 
 # Failed returns from this code are not real errors

--
Sven Wischnowsky                         wischnow@xxxxxxxxxxxxxxxxxxxxxxx