Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
OT: assignment to errno RE: PATCH: ptyread eating CPU on Cygwin
- X-seq: zsh-workers 13063
- From: "Andrej Borsenkow" <Andrej.Borsenkow@xxxxxxxxxxxxxx>
- To: "Sven Wischnowsky" <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>, <zsh-workers@xxxxxxxxxxxxxx>
- Subject: OT: assignment to errno RE: PATCH: ptyread eating CPU on Cygwin
- Date: Mon, 23 Oct 2000 12:15:22 +0400
- Importance: Normal
- In-reply-to: <200010230759.JAA21293@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
- Mailing-list: contact zsh-workers-help@xxxxxxxxxxxxxx; run by ezmlm
> + errno == EWOULDBLOCK
Not exactly relevant, but assignment to errno is a bad style. It may well be a
function (or some non-lvalue entity), espicially in case of threads support.
Also, I was really surprised recently to hear, that C9X and ISO C++ _require_
errno to be a macro.
There are probably many other places where errno is assigned to, of course.
But if we can avoid it - let's do it.
-andrej
Messages sorted by:
Reverse Date,
Date,
Thread,
Author