Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: OT: assignment to errno RE: PATCH: ptyread eating CPU on Cygwin

X-seq: zsh-workers 13064
From: Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>
To: zsh-workers@xxxxxxxxxxxxxx
Subject: Re: OT: assignment to errno RE: PATCH: ptyread eating CPU on Cygwin
Date: Mon, 23 Oct 2000 10:18:07 +0200 (MET DST)
In-reply-to: "Andrej Borsenkow"'s message of Mon, 23 Oct 2000 12:15:22 +0400
Mailing-list: contact zsh-workers-help@xxxxxxxxxxxxxx; run by ezmlm

Andrej Borsenkow wrote:

> > +	errno == EWOULDBLOCK
> 
> Not exactly relevant, but assignment to errno is a bad style. It may well be a
> function (or some non-lvalue entity), espicially in case of threads support.
> Also, I was really surprised recently to hear, that C9X and ISO C++ _require_
> errno to be a macro.
> 
> There are probably many other places where errno is assigned to, of course.
> But if we can avoid it - let's do it.

That's a comparison, not an assignment.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@xxxxxxxxxxxxxxxxxxxxxxx

Messages sorted by: Reverse Date, Date, Thread, Author