Re: PATCH: Block device tests

[Peter Stephenson <pws@xxxxxxx>]

"Bart Schaefer" wrote:
> On May 29, 11:34am, Peter Stephenson wrote:
> } Subject: Re: PATCH: Block device tests
> }
> } "Bart Schaefer" wrote:
> } > +  if ! grep '#define HAVE_FIFOS' $ZTST_testdir/../config.h; then
> } 
> } $ZTST_testdir is where we are running the tests.  Unfortunately this will
> } break if you are compiling separately from the source tree and then running
> } individual tests in the test directory
> 
> There are several other tests which rely on using a path relative to
> $ZTST_testdir:

The point was a little different: that config.h now has to be findable with
respect to wherever you're running the test, which therefore has to be the
Test subdirectory of the build.  Up to now, you could use the Test
subdirectory of the source tree, if different --- or anywhere else if you
adapted the path to the files in the latter directory.

On balance, it may be an advantage doing it this way: if we implement a way
of saying what's not implemented and hence shouldn't be checked on certain
systems, that's certainly going to have to go through one of the config.*
files.  In fact, we might get away with sourcing config.cache, and testing
the cv variables.  I won't be looking at that before the release.

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK                          Tel: +44 (0)1223 392070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************