Re: General unqueue_signal problem

[Peter Stephenson <pws@xxxxxxx>]

"Andrej Borsenkow" wrote:
> > cc -qlanglvl=ansi  -s  -o zftp.so -bI:../../Src/zsh.export
> > -bE:zftp.export -emodentry zftp..o  ../../Src/modentry..o  -ldl -lcurses
> > -lm  -lc
> > ld: 0711-317 ERROR: Undefined symbol: .handler
> 
> This comes from unqueue_signals() macro. This macro directly calls handler()
> from signals.c (at least, I presume it is this one). But as I understand,
> zftp.c sometimes install its own handler. Any other module may possible
> install own handler as well.
> 
> I do not understand how signal queuing works - anybody cares to check it? It
> is trivial to add mod_export to handler deinition - but I do not like it. At
> least, we should change the name then. handler is too cute for a globally
> visible function.

Adding mod_export is obviously the right first step, and probably ought to
fix this particular bug.  I haven't got time to change the name `handler'
at the moment, but replacing it by zhandler sounds sensible.

Index: Src/signals.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/signals.c,v
retrieving revision 1.17
diff -u -r1.17 signals.c
--- Src/signals.c	2001/05/23 08:53:12	1.17
+++ Src/signals.c	2001/06/13 09:28:31
@@ -400,7 +400,7 @@
 /* the signal handler */
  
 /**/
-RETSIGTYPE
+mod_export RETSIGTYPE
 handler(int sig)
 {
     sigset_t newmask, oldmask;

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Unit 300, Science Park, Milton Road,
Cambridge, CB4 0XL, UK                          Tel: +44 (0)1223 392070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************