Re: ignore-line style

[Oliver Kiddle <okiddle@xxxxxxxxxxx>]

Sven Wischnowsky wrote:
> 
> Here is what seems to fix it. It was using _comp_ignore on every level
> it walked through, hence `file' matched.
> 
> This seems almost too simple to not have any other effects, but let's
> try... (I'll leave it to Oliver to commit his patch).

As far as I can tell, this works very well. I've included testing of
this mixed with the ignored-patterns style and all seems well. The
explanation makes sense so hopefully there are no "other effects".
Thanks.

If this constitutes having got it working better as you said in you
first reply then I'd like to look at adding some of the suggestions I
made. For the styles, that was quoting to avoid globs, file like globs,
skipping command words and skipping options. To achieve file like
globs, one way would be to eval the words (something similar to
_expand) which would have the advantage of expanding braces and
variables too but process substitutions would be a problem. Have you
got any other ideas or suggestions?

The other suggestion was modifying _diff etc to set up the ignoring
without the need for a style. Can that be done better at the _files or
_arguments level at all? For what situations do you use the style and
can anyone think of any other commands where this ignoring could be
useful?

Thanks again

Oliver