Re: PATCH: completion listing and singlelinezle

[Peter Stephenson <pws@xxxxxxx>]

Geoff Wing wrote:
> : As far as I can see in zrefresh(), with singlelinezle it gives up
> : (zle_refresh.c:394ff) before coming to the code that decides whether
> : the list has to be displayed (line 650).
> 
> Found out that zle_refresh.c didn't have any goto statements in it yet
> so I thought I better do one :-)

The patch certainly seems to do the trick... I don't think anything more
sophisticated is needed with singlelinezle.  If you commit this, I'll
produce 4.1.0-dev-4, since it's high time.  It could also go on the 4.0
line.

There's no target date for 4.1.1; I'm still vaguely waiting for some
major change to justify it, in particular improvements in the parameter
code to make things like discipline functions easier.  But every time I
look at the code I stop looking at it after a bit.  The only vague
conclusion I've come to is that it might be a good idea to use some form
of vtable for storing stuff common to all parameters of a particular
type, which would save a bit of space with negligible impact on
performance.  But since discipline functions have to be specific to
individual parameters, it doesn't help us there at all.

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 392070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************