Re: Bug in history changes

[Peter Stephenson <pws@xxxxxxx>]

Peter Stephenson wrote:
> Wayne Davison wrote:
> > On Wed, 20 Feb 2002, Peter Stephenson wrote:
> > > The latest version of the history code is causing zcalc to crash.
> > 
> > I'm ashamed to say that my last patch still left a stupid bug in
> > prepnexthistent().  I just committed the following fix to CVS.
> 
> I'm still getting the crash after recompiling.

It seems to be the code with HISTEXPIREDUPSFIRST in
putoldhistentryontop() setting the next pointer to something that's
about to be free, but I don't remotely understand the code well enough
to be sure.  I made it go away by setting next to NULL if it was
pointing to something that was being freed, but I have no idea if this
is correct, or if that should ever happen.

Whether or not I do that, I now get:

+11:15% unsetopt histexpiredupsfirst
+11:15% HISTSIZE=1
+11:15% h
fc: no such event: 832

This doesn't happen if HISTSIZE is 2 or larger.

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 392070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************