Re: new valgrind errors

[Sven Wischnowsky <wischnow@xxxxxxxxx>]

Felix Rosencrantz wrote:

> Here is condensed output based on the latest changes.  -FR.
>  ERROR SUMMARY: 1537 errors from 12 contexts (suppressed: 24 from 1)
>  
>  11 errors in context 1 of 12:
>  Invalid read of size 4
>     at 0x80A49C3: pattryrefs (pattern.c:1357)
>     by 0x80A4952: pattry (pattern.c:1331)
>     by 0x413B1E39: lookupstyle (zutil.c:247)
>     by 0x413B27C4: bin_zstyle (zutil.c:439)
>     Address 0x4105951C is 20 bytes inside a block of size 80 free'd
>     at 0x40040311: free (vg_clientfuncs.c:156)
>     by 0x808C737: zfree (mem.c:1391)
>     by 0x80A7229: freepatprog (pattern.c:2326)
>     by 0x413B1912: setstypat (zutil.c:135)

Argh. That part of the patch was a thinko. Re-fix below.

But then I don't see how the original error came to pass.


Bye
  Sven

Index: Src/Modules/zutil.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/zutil.c,v
retrieving revision 1.10
diff -u -r1.10 zutil.c
--- Src/Modules/zutil.c	24 Apr 2002 07:59:19 -0000	1.10
+++ Src/Modules/zutil.c	25 Apr 2002 07:29:24 -0000
@@ -132,7 +132,6 @@
 		freearray(p->vals);
 	    if (p->eval)
 		freeeprog(p->eval);
-            freepatprog(p->prog);
 	    p->vals = zarrdup(vals);
 	    p->eval = eprog;
 

-- 
Sven Wischnowsky                          wischnow@xxxxxxxxx