Re: Menu selection

[Sven Wischnowsky <wischnow@xxxxxxxxx>]

Felix Rosencrantz wrote:

> Sorry to be the bearer of bad news...
> 
> I'm still seeing problems with the changes made to menu-select/vi-insert.
> Below is the same simple recipe that causes the problem.  Also, attached is the
> output of this recipe run under valgrind.   It points to memory reads of
> data that has already been free'd.
> 
> I actually don't really use this functionality much, but hope it might
> someday be used in a version of history-incremental-search-*ward.
> So that the incremental search can use a matching-spec....

Sigh. You're right, invalidatelist() could be called at the wrong time.


Bye
  Sven

Index: Src/Zle/compresult.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/compresult.c,v
retrieving revision 1.45
diff -u -r1.45 compresult.c
--- Src/Zle/compresult.c	26 Jun 2002 11:07:46 -0000	1.45
+++ Src/Zle/compresult.c	30 Jul 2002 07:45:30 -0000
@@ -813,7 +813,7 @@
 	 * want to enter an AUTO_MENU imediately.                          */
 	if ((uselist == 3 ||
 	     (!uselist && isset(BASHAUTOLIST) && isset(LISTAMBIGUOUS))) &&
-	    la) {
+	    la && iforcemenu != -1) {
 	    int fc = fromcomp;
 
 	    invalidatelist();

-- 
Sven Wischnowsky                          wischnow@xxxxxxxxx