Re: Memory leaks found by valgrind

[Peter Stephenson <pws@xxxxxxx>]

Felix Rosencrantz wrote:
> 659 bytes in 4 blocks are definitely lost in loss record 8 of 13
>    at 0x40165A60: malloc (vg_clientfuncs.c:100)
>    by 0x8086055: zalloc (mem.c:490)
>    by 0x80E2122: calclist (compresult.c:1583)
>    by 0x80E8750: complistmatches (complist.c:1607)

Most of the amatches linked list is on the heap (according to one
comment), but the widths element of each structure is dynamically
allocated.  It's hard to see when it should be freed.  It's currently
only allocated and freed in one function (calclist()); maybe that
function simply needs more logic, but I can't be sure.

> (This one seems to have come from children processes.)
> 464 bytes in 4 blocks are definitely lost in loss record 5 of 11
>    at 0x40165A60: malloc (vg_clientfuncs.c:100)
>    by 0x80861D5: zcalloc (mem.c:508)
>    by 0x807983C: addproc (jobs.c:832)
>    by 0x805D6BE: execpline (exec.c:1057)

I presume this is because when we enter a subshell we don't completely
delete the stuff in the job table, just delete a few bits of it and zero
the rest out.  I have a patch for this at home, but it's not a major
problem.  The only case I can see where it would become one was a
long-lived shell instance recursively starting a subshell while the
original shell exited, which isn't a normal use.

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************