Re: Yank-pop Dumps Core

[Peter Stephenson <pws@xxxxxxx>]

Vin Shelton wrote:
> In the latest CVS sources, the following recipe dumps core:
> 
> zsh -f
> bindkey -e
> asdf^A^K^Y<esc>y

Thanks for spotting this.  Here's cant_yankpop_if_no_kring.dif.

You should find the bug only happened if you'd done exactly one kill.

Index: Src/Zle/zle_misc.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_misc.c,v
retrieving revision 1.7
diff -u -r1.7 zle_misc.c
--- Src/Zle/zle_misc.c	27 Jan 2003 14:55:00 -0000	1.7
+++ Src/Zle/zle_misc.c	27 Feb 2003 11:22:49 -0000
@@ -372,7 +372,7 @@
     int cc, kctstart = kct;
     Cutbuffer buf;
 
-    if (!(lastcmd & ZLE_YANK))
+    if (!(lastcmd & ZLE_YANK) || !kring)
 	return 1;
     do {
 	/*

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************