Re: PATCH: Re: Bugs thrown up by _perforce

[Peter Stephenson <pws@xxxxxxx>]

Oliver Kiddle wrote:
> On 25 Feb, Peter wrote:
> > > [_next_tags always inserts an unambiguous completion]
> > >
> 
> This patch is my fix for the first of the problems. From my own usage,
> I'm happy that this is definitely better. If anyone really does want
> _next_tags to insert unambiguous matches, it would be easy to make it
> check the insert-unambiguous style.

The current change seems perfectly reasonable.

I finally got around to testing the other fix; it seems to do what I
want now, thanks (at least in _perforce, which is quite a serious test).
This notes the fact in the _perforce comments.

Index: Completion/Unix/Command/_perforce
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_perforce,v
retrieving revision 1.3
diff -u -r1.3 _perforce
--- Completion/Unix/Command/_perforce	23 Feb 2003 16:06:06 -0000	1.3
+++ Completion/Unix/Command/_perforce	12 Mar 2003 11:45:44 -0000
@@ -63,10 +63,13 @@
 # typing @ or # removes the space which was automatically added.
 # The context used has `at-suffix' or `hash-suffix' in the position
 # before the tag to indicate suffix completion (as always, ^Xh will
-# show you all possible contexts).  This should make it possible
+# show you all possible contexts).  This makes it possible
 # to select changes, dates, labels and clients using the tag-order
-# style, but unfortunately there is a bug which stops any tags afer
-# the first group from being displayed.
+# style.  For example,
+#    zstyle ':completion:*:p4-*:at-suffix:*' tag-order changes '*'
+# will force all completion after `@' to show changes first.  Executing
+# _next_tags (usually ^x^n) will cycle between that and the remaining
+# tags (dates, labels, clients).
 #
 # A # is automatically quoted when handled in this way; if the file is
 # typed by hand or the completion didn't finish (e.g. you typed a character

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************