Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Segmentation fault caused by completion system

X-seq: zsh-workers 18467
From: Peter Stephenson <pws@xxxxxxxxxxxxxxxxxxxxxxxx>
To: "Haakon Riiser" <haakon.riiser@xxxxxxxxxx>, zsh-workers@xxxxxxxxxx
Subject: Re: Segmentation fault caused by completion system
Date: Wed, 23 Apr 2003 18:49:33 +0100
In-reply-to: ""Haakon Riiser""'s message of "Thu, 17 Apr 2003 18:02:34 +0200." <20030417160234.GA4940@s>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm

"Haakon Riiser" wrote:
> "*" in front of "-+" or "+-" in the optspecs to "_arguments"
> causes a segmentation fault on completion.

This appears to be a trivial fix.

Index: Src/Zle/computil.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/computil.c,v
retrieving revision 1.83
diff -u -r1.83 computil.c
--- Src/Zle/computil.c	27 Aug 2002 21:10:34 -0000	1.83
+++ Src/Zle/computil.c	23 Apr 2003 18:43:45 -0000
@@ -1397,7 +1397,7 @@
 		    opt->descr = NULL;
 	    } else
 		opt->descr = NULL;
-	    opt->xor = (again == 1 ? zarrdup(xor) : xor);
+	    opt->xor = (again == 1 && xor ? zarrdup(xor) : xor);
 	    opt->type = otype;
 	    opt->args = oargs;
 	    opt->num = nopts++;

-- 
Peter Stephenson <pws@xxxxxxxxxxxxxxxxxxxxxxxx>
Work: pws@xxxxxxx
Web: http://www.pwstephenson.fsnet.co.uk

References:
- Segmentation fault caused by completion system
  - From: Haakon Riiser

Messages sorted by: Reverse Date, Date, Thread, Author