Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: fix menu completion on terminal with do=^J/without do

X-seq: zsh-workers 18491
From: Wayne Davison <wayned@xxxxxxxxxxxxxxxxxxxxx>
To: Andrey Borzenkov <arvidjaar@xxxxxxx>
Subject: Re: PATCH: fix menu completion on terminal with do=^J/without do
Date: Wed, 30 Apr 2003 08:55:25 -0700
Cc: zsh-workers@xxxxxxxxxx
In-reply-to: <200304271249.49111.arvidjaar@xxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <200304271249.49111.arvidjaar@xxxxxxx>

On Sun, Apr 27, 2003 at 12:49:49PM +0400, Andrey Borzenkov wrote:
> The patch exports tc_downcurs and makes complist using it.

Yes, this seems to be the right thing to do.  Because the init_term()
code may have completely disabled all known downward-motion capabilities
(when it removed "do=^J"), zsh must always call tc_downcurs(ct) instead
of trying to call tcmultout(TCDOWN, TCMULTDOWN, ct) directly.  It must
also be prepared to handle a non-zero return code which indicates that
the cursor has moved to column 0.

In the case of your patch, it appears that the calling code always
returns the cursor to column 0 before calling tc_downcurs(), so I
believe your patch to be the right fix.

..wayne..

References:
- PATCH: fix menu completion on terminal with do=^J/without do
  - From: Andrey Borzenkov

Messages sorted by: Reverse Date, Date, Thread, Author