Re: Link error from latest CVS

[Peter Stephenson <pws@xxxxxxx>]

Vin Shelton wrote:
> Peter,
> 
> Using the latest sources from CVS, I cannot link.  Here are the errors:
> 
> Modules/parameter.o(.text+0x31b5): In function `setpmdisgalias':
> : undefined reference to `setgalias'
> Modules/parameter.o(.text+0x31e5): In function `setpmsalias':
> : undefined reference to `setgalias'
> Modules/parameter.o(.text+0x3215): In function `setpmdissalias':
> : undefined reference to `setgalias'
> collect2: ld returned 1 exit status
> 
> Did you not check in part of your latest patch?

It was a typo; the lazy linkers I have didn't report it.  It wasn't the
only typo, either, as I discovered when I tried assigning to saliases.
We need test scripts for the modules.  To put it unambiguously, we need
someone to write test scripts for the modules.

Index: Src/Modules/parameter.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/parameter.c,v
retrieving revision 1.25
diff -u -r1.25 parameter.c
--- Src/Modules/parameter.c	3 Sep 2003 10:15:36 -0000	1.25
+++ Src/Modules/parameter.c	8 Sep 2003 09:54:51 -0000
@@ -1617,7 +1617,7 @@
 static void
 setalias(HashTable ht, Param pm, char *value, int flags)
 {
-    ht->addnode(aliastab, ztrdup(pm->nam),
+    ht->addnode(ht, ztrdup(pm->nam),
 		createaliasnode(value, flags));
 }
 
@@ -1646,21 +1646,21 @@
 static void
 setpmdisgalias(Param pm, char *value)
 {
-    setgalias(aliastab, pm, value, ALIAS_GLOBAL|DISABLED);
+    setalias(aliastab, pm, value, ALIAS_GLOBAL|DISABLED);
 }
 
 /**/
 static void
 setpmsalias(Param pm, char *value)
 {
-    setgalias(sufaliastab, pm, value, 0);
+    setalias(sufaliastab, pm, value, ALIAS_SUFFIX);
 }
 
 /**/
 static void
 setpmdissalias(Param pm, char *value)
 {
-    setgalias(sufaliastab, pm, value, DISABLED);
+    setalias(sufaliastab, pm, value, ALIAS_SUFFIX|DISABLED);
 }
 
 /**/

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************