Re: autoconf 2.5 (Re: PATCH: terminfo horor)

[Oliver Kiddle <okiddle@xxxxxxxxxxx>]

On 25 Dec, Andrey wrote:

> - autoconf 2.5 does not create anything in configure. Instead the sole point
> of configure script is to create config.status - and it is config.status
> that finally does (should do) the job of creating files, making
> substitutions etc

Taking that, what we should probably do is have configure not create
any config.modules files but have it do the work of config.modules.sh,
putting the results directly into config.status in such a way that
config.status will create the config.modules file.

> What I intended was to allow modules to supply "configure plugins" to make
> whatever checks are needed; then configure could simply emit list modules to
> build without generating (mostly identical) makefile fragments for every
> module. Hmm ... it does look suspiciously similar to linux kernel, does not
> it? :)
> 
> But it is near to impossible to create such plugins as shell scripts
> (autoconf simply does not support it).
> 
> What is possible is to provide configure snippets and make Util/preconfig to
> generate modules.m4 that includes them' modules.m4 would then be included by
> zshconfig.ac. Unfortunately it is not easy to handle dependencies (i.e.
> module added or removed after modules.m4 has been created). 

I don't know much about how the linux kernel handles things. The idea
of having configure snippets that are included as part of zshconfig.ac
sounds good. Would allow us to separate out configure tests that are
specific to a module.

Peter wrote:
> Can someone confirm this is a suitable patch for removing support for
> old versions of autoconf, together with deleting configure.in which I
> will commit at the same time?

That does solve the problem I had because config.status no longer
writes out a crap config.modules. Only trouble is that, as Bart points
out, those lines are needed when someone runs just config.status.

I suggest you go ahead with the rest of the patch. Except there's a
typo (arlier) and you could also merge zshconfig.ac into configure.ac -
there's no need for a separate file.

Oliver