Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Coredump in test B02 as of 2004-01-13

X-seq: zsh-workers 19376
From: Vin Shelton <acs@xxxxxxxxxxxxxxxxxxxx>
To: Peter Stephenson <pws@xxxxxxx>
Subject: Re: Coredump in test B02 as of 2004-01-13
Date: Thu, 15 Jan 2004 09:36:43 -0500
Cc: zsh-workers@xxxxxxxxxx
In-reply-to: <5197.1074163875@xxxxxxx> (Peter Stephenson's message of "Thu, 15 Jan 2004 10:51:15 +0000")
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
Organization: Teradyne, Inc
References: <5197.1074163875@xxxxxxx>

Peter Stephenson <pws@xxxxxxx> writes:

> Vin Shelton wrote:
>> Greetings,
>> 
>> On my SunOS systems at work I'm seeing the following failure in the
>> testsuite when running against a build of 2004-01-13:
>
> Reduces to:
>
>   unset argv
>   print $#
>
> Right idea, wrong number of ampersands.
>
> Index: Src/params.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/params.c,v
> retrieving revision 1.75
> diff -u -r1.75 params.c
> --- Src/params.c	12 Jan 2004 12:09:12 -0000	1.75
> +++ Src/params.c	15 Jan 2004 10:50:29 -0000
> @@ -2585,7 +2585,7 @@
>       * ways which need to be set to NULL.  We can't do this
>       * with user tied variables since we can leak memory.
>       */
> -    if ((pm->flags & PM_SPECIAL) & !x)
> +    if ((pm->flags & PM_SPECIAL) && !x)
>  	*dptr = mkarray(NULL);
>      else
>  	*dptr = x;
>

Yes, this fixes the coredump.  Thanks, Peter!

  - Vin

References:
- Re: Coredump in test B02 as of 2004-01-13
  - From: Peter Stephenson

Messages sorted by: Reverse Date, Date, Thread, Author