Re: PATCH: strftime -s

[Peter Stephenson <pws@xxxxxxx>]

Peter Stephenson wrote:
> It also fixes a bug that the EPOCHSECONDS wasn't unset when the module
> was unloaded, which could have nasty effects.  There ought to be
> something in the development guide about this.  (Ideally, there ought to
> be an easier way of removing module parameters --- it's a bit hairy at
> the moment.)

grrr... I'm telling me... EPOCHSECONDS didn't have an unsetfn, so still
crashed when the module was unloaded.  Should we guard against this?
It's odd that readonly variables need an unsetfn (though I think it's
reasonable that you need to explicitly remove the readonly flag when
unsetting).

Committed with that change.

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.

www.mimesweeper.com
**********************************************************************