Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: vux/vuxctl completion



> Sorry to winge about this but could we please have consistency on
> indentation across completion functions. Convention is for two spaces.

> Those actions could really do with descriptions:
>   '...:((p\:description g\:...))'
> works.

> This should really have an _wanted before it. We should never be adding
> matches without some sort of description.

Index: Completion/Unix/Command/_vux
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_vux,v
retrieving revision 1.1
diff -u -r1.1 _vux
--- Completion/Unix/Command/_vux	11 Mar 2004 21:29:49 -0000	1.1
+++ Completion/Unix/Command/_vux	12 Mar 2004 15:13:59 -0000
@@ -1,10 +1,15 @@
 #compdef vux vuxctl
 
+local expl
+
 case "$service" in
-	(vux)
+  (vux)
 
-_arguments -s -C \
-	'-x:action:(p g m w r f)' \
+  _arguments -s -C \
+	'-x:action:((play\:play\ music generate\:generate\ new\ scorelist
+	            merge\:merge\ new\ songs
+		    weed\:prune\ songs\ from\ scorelist
+		    ratings\:show\ statistics force\:force-rate))' \
 	'-s:file:_files' \
 	'-a:file:_files' \
 	'-z:file:_files' \
@@ -47,14 +52,13 @@
 	'-P[Always play new songs]' \
 	'-g[print stats in xgraph format]' \
 	'-h[Show summary of options]'
+  ;;
 
-	;;
-
-	(vuxctl)
-
-	compadd start clean double half up down next previous forward \
-		replay pause resume stop reload save history help
+  (vuxctl)
 
-	;;
+  _wanted vuxcmd expl 'vux control command' \
+      compadd start clean double half up down next previous forward \
+	      replay pause resume stop reload save history help
+  ;;
 
 esac



Messages sorted by: Reverse Date, Date, Thread, Author