Re: Spring patch clean-up: HAVE_BROKEN_TCSETPGRP and backgrounded ./configure

[Philippe Troin <phil@xxxxxxxx>]

Peter Stephenson <pws@xxxxxxx> writes:

> I'll commit this patch with the following additional information.

Thanks Peter.

Nitpicking:
 
> +A test for the function tcsetpgrp is turned on by default.  The test needs
> +to run the function to determine if the implementation is usable. However,
> +this can cause problems when configure is run without a terminal.  To avoid
> +this, use --with-tcsetpgrp or --without-tcsetpgrp to tell configure whether
> +the function should be used.
> +

should be replaced by:

A test for the function tcsetpgrp is turned on by default.  The test
needs to run the function to determine if the implementation is
usable. However, this can cause problems when configure is run without
a controlling terminal (eg. from cron).  To avoid this, use
--with-tcsetpgrp or --without-tcsetpgrp to tell configure whether the
function should be used.

One can run with on a terminal without it being the controlling
terminal. Like when doing clone /dev/pts/<n>, the cloned zsh is
running on a tty, but has no ctty.

Phil.