Re: Bug with the new prompt redraw code

[Peter Stephenson <pws@xxxxxxx>]

Bart Schaefer wrote:
> On Sun, 11 Jul 2004, Peter Stephenson wrote:
> 
> > > > > (1) zle-line-init runs before the prompt is displayed
> 
> So, what about (1)?  To repeat, the intent was to display a multi-line 
> prompt immediately after a command finishes, but then refresh only the 
> last line of that prompt on subsequent zle redisplays (the original 
> example involved SIGWINCH handling).
> 
> An almost-equivalent thing can be achieved by using "print -P" from the
> precmd function instead of by assignment to PS1, but there's a question
> of whether other commands in zle-line-init should affect values that are
> substituted into the prompt (e.g. $psvar).

It sounds like zrefresh() should be moved earlier, out of zlecore().

This means zle-line-init is basically the last thing executed before the
editor starts looking for input.  Hence zle-line-init will only affect
the next prompt, but the previous prompt will have been drawn.

Maybe that's right.

Index: Src/Zle/zle_main.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_main.c,v
retrieving revision 1.48
diff -u -r1.48 zle_main.c
--- Src/Zle/zle_main.c	11 Jul 2004 22:53:04 -0000	1.48
+++ Src/Zle/zle_main.c	12 Jul 2004 17:48:57 -0000
@@ -680,8 +680,6 @@
     FD_ZERO(&foofd);
 #endif
 
-    zrefresh();
-
     while (!done && !errflag) {
 
 	statusline = NULL;
@@ -834,6 +832,8 @@
     initmodifier(&zmod);
     prefixflag = 0;
 
+    zrefresh();
+
     if ((initthingy = rthingy_nocreate("zle-line-init"))) {
 	char *args[2];
 	args[0] = initthingy->nam;
@@ -1303,6 +1303,7 @@
 {
     int locerror;
 
+    zrefresh();
     zlecore();
 
     locerror = errflag;

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.

www.mimesweeper.com
**********************************************************************