Re: Any comments on users/7883 ?

[Peter Stephenson <pws@xxxxxxx>]

Bart Schaefer wrote:
> (It looks like nobody understands this code, me included.  Did Zefram 
> write it, originally?)

Probably, unless it's even older.

> This is the key bit here.  I think the right fix is to check "is_builtin"
> not "hn == (HashNode)&commandbn" -- and that it's not necessary to && it
> with (cflags & BINF_COMMAND) the way you have.

This may be the best we're going to get.

> (Is it just me, or is there a crash waiting to happen at line 1828 in the
> event of a badly written module?)

You mean before the patch?

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.

www.mimesweeper.com
**********************************************************************