Re: 4.2.4 failure on MacOS X

["Peter A. Castro" <doctor@xxxxxxxxxxxx>]

On Fri, 4 Feb 2005, Motoi Washida wrote:

> I also failed to build zsh on Mac OS X 10.3.7.
>
> I think this is because configure can't find iconv(), because iconv()
> is defined as libiconv() in /usr/include/iconv.h and the configure
> script checks iconv() without using the header file.
>
> I modified configure.ac a bit and seems to work. Here is the patch.

Excellent!  It seems Darwin and Cygwin share a similar implementation.
Maybe it can simply be made generic? :

AC_CHECK_LIB(iconv, iconv)
AC_CHECK_LIB(iconv, libiconv)

Presumably it's unlikely that both iconv() and libiconv() would exist?

FWIW, I did hack an iconv test which #include the header, if detected,
but this started to get more complicated than it was worth and opt'ed for
simply looking for the real symbol name.

> --
> Motoi Washida
>
>
>
> Index: configure.ac
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/configure.ac,v
> retrieving revision 1.25
> diff -d -u -r1.25 configure.ac
> --- configure.ac	1 Feb 2005 10:53:10 -0000	1.25
> +++ configure.ac	3 Feb 2005 18:42:05 -0000
> @@ -729,10 +729,11 @@
>
>   AC_CHECK_LIB(iconv, iconv)
>
> -if test "$host_os" = cygwin; then
> -dnl cygwin iconv() is really libiconv()
> -AC_CHECK_LIB(iconv, libiconv)
> -fi
> +case "$host_os" in
> +  cygwin | darwin*)
> +    dnl cygwin iconv() is really libiconv()
> +    AC_CHECK_LIB(iconv, libiconv) ;;
> +esac
>
>   if test x$enable_pcre = xyes; then
>   dnl pcre-config should probably be employed here

-- 
Peter A. Castro <doctor@xxxxxxxxxxxx> or <Peter.Castro@xxxxxxxxxx>
	"Cats are just autistic Dogs" -- Dr. Tony Attwood