Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [stew@xxxxxxxxx: Bug#295511: patch]
- X-seq: zsh-workers 20915
- From: Wayne Davison <wayned@xxxxxxxxxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxxxxx
- Subject: Re: [stew@xxxxxxxxx: Bug#295511: patch]
- Date: Wed, 2 Mar 2005 10:51:47 -0800
- In-reply-to: <20050302052845.GA27771@xxxxxxxxxxx>
- Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
- References: <20050302052845.GA27771@xxxxxxxxxxx>
On Wed, Mar 02, 2005 at 12:28:45AM -0500, Clint Adams wrote:
> Wayne, any thoughts?
Hmm, I failed to notice that this Debian bug was talking about the _make
completer. It looks to me like the main problem is that the script has
a reference to $1 in some $(shell ...) expansions, and the _make script
is expanding this into the arg that is being expanded, causing an
infinite loop. So, I think it would be good to work up a patch that
would cause the _make script to avoid trying to expand (or set) numeric
arg variables (I'll look into this).
However, the patch you cited that limits recursion-depth also appears to
be a reasonable precaution to avoid a problem like this in the future.
It looks good enough to check-in to me -- if you agree, feel free (or
ask me to do so).
..wayne..
Messages sorted by:
Reverse Date,
Date,
Thread,
Author